Ticket #590 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

PackageDepSpec cannot be created if package name ends with a hyphen

Reported by: ColdWind Owned by:
Priority: MinorRelease Milestone: EAPI 0 (PMS)
Component: core/paludis Version: 0.26.2
Keywords: Cc:
Blocked By: Blocking: 611
Distribution: Gentoo

Description

PackageDepSpec? cannot be created if package name ends with a hyphen. PMS specifies doesn't restrict this case.

Attachments

pds-final-hyphens.patch Download (2.7 KB) - added by ColdWind 12 years ago.
pds-final-hyphens.patch

Change History

Changed 12 years ago by ColdWind

pds-final-hyphens.patch

comment:1 Changed 12 years ago by ciaranm

Doesn't this get =cat/foo----2 wrong?

comment:2 Changed 12 years ago by ColdWind

Nope. =========== These packages will be installed:

  • my.shiny_category-/mypkg-----::local :0-. [N 0-r0] <target>

===========

comment:3 Changed 12 years ago by ciaranm

Doesn't this get =cat/foo---- wrong, in that it doesn't throw the right exception?

comment:4 Changed 12 years ago by ciaranm

  • Blocking set to 611

comment:5 Changed 12 years ago by ciaranm

So I don't forget... It's a single hyphen that breaks. Multiple hyphens works.

comment:6 Changed 12 years ago by ciaranm

It has come to my attention that I don't have a frickin' clue what that bit of code is playing at. So I think it's time to rewrite the damned thing and remove most of the duplication between elike and user parsing.

comment:7 Changed 12 years ago by ciaranm

  • Status changed from new to closed
  • Resolution set to fixed

975ba82125af / d5e5befd325a

Note: See TracTickets for help on using tickets.