Ticket #351 (closed enhancement: fixed)

Opened 7 years ago

Last modified 6 years ago

Make symlink rewriting EAPI configurable

Reported by: ciaranm Owned by: ferdy
Priority: Sometime Milestone: EAPI exheres-0
Component: core/paludis Version: scm
Keywords: Cc:
Blocked By: Blocking:
Distribution:

Description

Symlink rewriting should be fatal rather than a warning for some EAPIs.

Change History

comment:1 Changed 6 years ago by ciaranm

It should probably also be part of the merger, rather than a hook.

comment:2 Changed 6 years ago by ferdy

  • Owner changed from ciaranm to ferdy
  • Status changed from new to assigned

I take this one. Things to do:

  • Add a 'rewrite_symlinks' parameter to EAPIEbuildOptions.
  • Add a 'rewrite_symlinks' member to MergerOptions.
  • Make VDBMerger and NDBAMMerger pass package_id->eapi()->supported()->ebuild_options()->rewrite_symlinks() while constructing their Merger bases.
  • Modify on_sym_over_{file, sym, nothing} to call a new function that rewrites symlinks as needed.

Did I miss something?

  • ferdy

comment:3 Changed 6 years ago by ciaranm

NDBAM doesn't do EAPI, so you'll have to pass a sane default there. Also, supported and ebuild_options aren't functions.

comment:4 Changed 6 years ago by ferdy

  • Status changed from assigned to accepted

Patches sent to -sekrit.

comment:5 Changed 6 years ago by ferdy

  • Status changed from accepted to closed
  • Resolution set to fixed

r4147

Note: See TracTickets for help on using tickets.