Ticket #1036 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

export_exlib_phases should error if the stated phases aren't there

Reported by: greenrd Owned by:
Priority: Sometime Milestone:
Component: core/paludis Version: scm
Keywords: Cc:
Blocked By: Blocking:
Distribution: Exherbo

Description

I had a typo in my magit.exlib:

magic_src_compile() {

instead of

magit_src_compile() {

I didn't notice the error until now, because make install noticed that the compile hadn't been done, and compiled everything. export_exlib_phases should have noticed this.

Attachments

0002-Detect-undefined-exported-exlib-phases.patch Download (1.4 KB) - added by ciaranm 8 years ago.

Change History

comment:1 Changed 8 years ago by ciaranm

Slightly tricky, because export_exlib_phases is called before the functions are defined.

comment:2 Changed 8 years ago by greenrd

Actually, there was an error at some stage (command not found, I think) - trouble is, it wasn't fatal.

comment:3 Changed 8 years ago by ciaranm

        eval "${e}() { ${CURRENT_EXLIB}_${e} \"\$@\" ; }"

Maybe we could throw a type -f in there.

Changed 8 years ago by ciaranm

comment:4 Changed 8 years ago by ciaranm

How does the attached look?

comment:5 Changed 8 years ago by ciaranm

  • Status changed from new to closed
  • Resolution set to fixed

I think this is as fixed as it reasonably can be.

Note: See TracTickets for help on using tickets.